Skip to content

fix: store forked derived values #17212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 24, 2025
Merged

fix: store forked derived values #17212

merged 4 commits into from
Nov 24, 2025
+48 −3

Conversation

@paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Nov 21, 2025 •
edited
Loading

Closes #17206

For some reason, despite a situation like this being the input for the second commit in #17163 we still ended up ignoring it.

This fixes it, however it introduces a new Map which I'm not too happy with...we could maybe do something with the batch itself?

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: b769107

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Playground

pnpm add https://pkg.pr.new/svelte@17212

@sillvva
Copy link

sillvva commented Nov 21, 2025 •
edited
Loading

This fixes #17206

Before: (hovering link causes dev console error)
https://stackblitz.com/edit/sveltejs-kit-template-default-j4cmhsez?file=package.json,src%2Froutes%2F%2Bpage.svelte,src%2Froutes%2Ftest%2F%2Bpage.svelte

After: (no error, link works as expected)
https://stackblitz.com/edit/sveltejs-kit-template-default-ypaqodke?file=package.json,src%2Froutes%2F%2Bpage.svelte,src%2Froutes%2Ftest%2F%2Bpage.svelte

@sillvva sillvva mentioned this pull request Nov 22, 2025
Closed
@dummdidumm
Copy link
Member

dummdidumm commented Nov 24, 2025

This fails if you update and then read because there's no chance for batch_values to clear itself, example. Still, I'm somewhat inklined to merge because this is still better than what we have right now

@paoloricciuti
Copy link
Member Author

paoloricciuti commented Nov 24, 2025

This fails if you update and then read because there's no chance for batch_values to clear itself, example. Still, I'm somewhat inklined to merge because this is still better than what we have right now

I feel like we should always update inside forks...we could technically do it, but would that be wasteful and possibly performance problematic?

@paoloricciuti
Copy link
Member Author

paoloricciuti commented Nov 24, 2025

@dummdidumm last commit fixes your playground while keeping CI green (maybe we should also update the test to include the second write)...but I'm really not convinced it's the right solution...it feels wasteful (but more correct so maybe is fine?)

dummdidumm
dummdidumm approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah that works - made it less expensive and updated the test. Thank you!

@dummdidumm dummdidumm merged commit ea8838e into main Nov 24, 2025
18 checks passed
@dummdidumm dummdidumm deleted the forked-derived-values branch November 24, 2025 21:41
@github-actions github-actions bot mentioned this pull request Nov 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[5.43.13] Hover preload error: props_invalid_value

4 participants

@paoloricciuti @sillvva @dummdidumm